From 2c209d7dcc6c3486a409741a5daaaf1f67e73336 Mon Sep 17 00:00:00 2001
From: quiquelhappy <quiquelhappy@gmail.com>
Date: Sat, 20 Nov 2021 20:18:10 +0100
Subject: [PATCH] check if release has suggestions if unknown before
 downloading, so provided suggestions can be used safely

---
 .idea/workspace.xml             | 38 ++++++++++++++++++++++++++++-----
 src/api/Globals.go              |  2 +-
 src/elements/project/Release.go | 22 ++++++++++++++++++-
 3 files changed, 55 insertions(+), 7 deletions(-)

diff --git a/.idea/workspace.xml b/.idea/workspace.xml
index cd8805d..fe5b07b 100644
--- a/.idea/workspace.xml
+++ b/.idea/workspace.xml
@@ -7,6 +7,12 @@
     <list default="true" id="5849f9c3-6ea4-420c-822c-d2a08705a5b1" name="Changes" comment="">
       <change beforePath="$PROJECT_DIR$/.idea/workspace.xml" beforeDir="false" afterPath="$PROJECT_DIR$/.idea/workspace.xml" afterDir="false" />
       <change beforePath="$PROJECT_DIR$/src/api/Globals.go" beforeDir="false" afterPath="$PROJECT_DIR$/src/api/Globals.go" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/elements/project/DownloadableRelease.go" beforeDir="false" afterPath="$PROJECT_DIR$/src/elements/project/DownloadableRelease.go" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/elements/project/Project.go" beforeDir="false" afterPath="$PROJECT_DIR$/src/elements/project/Project.go" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/elements/project/ProjectLock.go" beforeDir="false" afterPath="$PROJECT_DIR$/src/elements/project/ProjectLock.go" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/elements/project/Release.go" beforeDir="false" afterPath="$PROJECT_DIR$/src/elements/project/Release.go" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/elements/project/Resource.go" beforeDir="false" afterPath="$PROJECT_DIR$/src/elements/project/Resource.go" afterDir="false" />
+      <change beforePath="$PROJECT_DIR$/src/go.mod" beforeDir="false" afterPath="$PROJECT_DIR$/src/go.mod" afterDir="false" />
     </list>
     <option name="SHOW_DIALOG" value="false" />
     <option name="HIGHLIGHT_CONFLICTS" value="true" />
@@ -20,13 +26,16 @@
       </list>
     </option>
   </component>
-  <component name="GOROOT" url="file://$USER_HOME$/golang/sdk/go1.17" />
+  <component name="GOROOT" url="file://$USER_HOME$/sdk/go1.17.3" />
   <component name="Git.Settings">
     <option name="RECENT_GIT_ROOT_PATH" value="$PROJECT_DIR$" />
   </component>
   <component name="GoLibraries">
     <option name="indexEntireGoPath" value="false" />
   </component>
+  <component name="Make.Settings">
+    <option name="path" value="C:\ProgramData\chocolatey\bin\make.exe" />
+  </component>
   <component name="ProjectId" id="1yBOAzwRr6t52NYWnWPiYEmmev8" />
   <component name="ProjectLevelVcsManager" settingsEditedManually="true" />
   <component name="ProjectViewState">
@@ -43,13 +52,22 @@
     <property name="go.modules.go.list.on.any.changes.was.set" value="true" />
     <property name="go.sdk.automatically.set" value="true" />
     <property name="go.vendoring.notification.had.been.shown" value="true" />
-    <property name="last_opened_file_path" value="$PROJECT_DIR$" />
-    <property name="settings.editor.selected.configurable" value="goland.project.structure" />
+    <property name="last_opened_file_path" value="$PROJECT_DIR$/../../../../../../ProgramData/chocolatey/bin/make.exe" />
+    <property name="settings.editor.selected.configurable" value="preferences.pluginManager" />
   </component>
-  <component name="RunManager" selected="Makefile Target.build">
+  <component name="RunManager" selected="Go Build.windows">
+    <configuration default="true" type="GoApplicationRunConfiguration" factoryName="Go Application">
+      <module name="cli" />
+      <working_directory value="$PROJECT_DIR$" />
+      <go_parameters value="-i" />
+      <kind value="FILE" />
+      <directory value="$PROJECT_DIR$" />
+      <filePath value="$PROJECT_DIR$" />
+      <method v="2" />
+    </configuration>
     <configuration name="windows" type="GoApplicationRunConfiguration" factoryName="Go Application">
       <module name="cli" />
-      <working_directory value="$PROJECT_DIR$/target" />
+      <working_directory value="$PROJECT_DIR$/" />
       <go_parameters value="-o ./../target/grif_windows_x64.exe" />
       <kind value="DIRECTORY" />
       <directory value="$PROJECT_DIR$/src" />
@@ -57,6 +75,16 @@
       <output_directory value="$PROJECT_DIR$/target/" />
       <method v="2" />
     </configuration>
+    <configuration default="true" type="GoTestRunConfiguration" factoryName="Go Test">
+      <module name="cli" />
+      <working_directory value="$PROJECT_DIR$" />
+      <go_parameters value="-i" />
+      <kind value="DIRECTORY" />
+      <directory value="$PROJECT_DIR$" />
+      <filePath value="$PROJECT_DIR$" />
+      <framework value="gotest" />
+      <method v="2" />
+    </configuration>
     <configuration name="build" type="MAKEFILE_TARGET_RUN_CONFIGURATION" factoryName="Makefile">
       <makefile filename="$PROJECT_DIR$/makefile" target="" workingDirectory="$PROJECT_DIR$" arguments="">
         <envs />
diff --git a/src/api/Globals.go b/src/api/Globals.go
index 70b971c..26ffe9b 100644
--- a/src/api/Globals.go
+++ b/src/api/Globals.go
@@ -1,5 +1,5 @@
 package api
 
-const Version = "1.1.2"
+const Version = "1.1.3"
 const KeychainService = "grifpkg"
 const KeychainHash = "session"
\ No newline at end of file
diff --git a/src/elements/project/Release.go b/src/elements/project/Release.go
index dd48d7b..8dc4535 100644
--- a/src/elements/project/Release.go
+++ b/src/elements/project/Release.go
@@ -63,11 +63,31 @@ func (release Release) ListSuggestions() (suggestions []urlSuggestion.UrlSuggest
 	return suggestions, err
 }
 
+func (_ Release) Get(id string) (release Release, err error){
+	request, err := api.Request("resource/release/get/", map[string]interface{}{
+		"release": id,
+	}, nil)
+	if err != nil {
+		return Release{}, err
+	}
+	err = json.NewDecoder(request).Decode(&release)
+	if err != nil {
+		return Release{}, err
+	}
+	return release, nil
+}
+
 func (release Release) GetDownloadable(suggestionIdFallback interface{}) (downloadableRelease DownloadableRelease, err error) {
 	api.LogOne(api.Progress, "requesting downloadable release")
 	downloadableRelease = DownloadableRelease{}
+	if release.HasSuggestions==nil {
+		updatedRelease, err := release.Get(release.Id)
+		if err != nil {
+			return DownloadableRelease{}, err
+		}
+		release.HasSuggestions=updatedRelease.HasSuggestions
+	}
 	if release.HasSuggestions!=nil {
-
 		if release.HasSuggestions == true {
 			suggestionList, err := release.ListSuggestions()
 			if err!=nil {