Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xSmall Button - Token Review #4570

Open
CillianHPE opened this issue Dec 12, 2024 · 4 comments
Open

xSmall Button - Token Review #4570

CillianHPE opened this issue Dec 12, 2024 · 4 comments
Assignees
@CillianHPE
Labels
Phase:Current Sprint Used for issues that are being worked on current sprint.

Comments

@CillianHPE
Copy link
Collaborator

CillianHPE commented Dec 12, 2024 •
edited
Loading

Link to Figma
@CillianHPE CillianHPE added the Phase:Current Sprint Used for issues that are being worked on current sprint. label Dec 12, 2024
@CillianHPE CillianHPE assigned CillianHPE and julauxen and unassigned CillianHPE Dec 12, 2024
@julauxen
Copy link
Collaborator

hey @CillianHPE review done in branch.

@julauxen julauxen assigned CillianHPE and unassigned julauxen Dec 13, 2024
@CillianHPE
Copy link
Collaborator Author

@julauxen

Changes made.

Still waiting on a token for the hover effect though.

@CillianHPE CillianHPE assigned julauxen and unassigned CillianHPE Dec 13, 2024
@julauxen
Copy link
Collaborator

@CillianHPE second review done in the branch. There're only 2 comments, after those are fixed, I am good to close.

@julauxen julauxen assigned CillianHPE and unassigned julauxen Dec 16, 2024
@CillianHPE
Copy link
Collaborator Author

Publishing as done with token exceptions because hover token on Secondary xSmall variant is not ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CillianHPE CillianHPE

Labels
Phase:Current Sprint Used for issues that are being worked on current sprint.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@julauxen @CillianHPE