Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select [in FormField] - Token review #4606

Closed
SeamusLeonardHPE opened this issue Dec 17, 2024 · 6 comments
Closed

Select [in FormField] - Token review #4606

SeamusLeonardHPE opened this issue Dec 17, 2024 · 6 comments
Assignees
@SeamusLeonardHPE
Labels
Phase:Current Sprint Used for issues that are being worked on current sprint.

Comments

@SeamusLeonardHPE
Copy link
Collaborator

Link to test region

https://www.figma.com/design/5NUO23O2mDjiulO2H0S2Os/v2-Construction-Site?node-id=5050-196422&t=NPGWU78NgJnRo7M3-4
@SeamusLeonardHPE SeamusLeonardHPE added the Phase:Current Sprint Used for issues that are being worked on current sprint. label Dec 17, 2024
@SeamusLeonardHPE SeamusLeonardHPE mentioned this issue Dec 17, 2024
Open
@julauxen
Copy link
Collaborator

hey @SeamusLeonardHPE Review done here.

@SeamusLeonardHPE
Copy link
Collaborator Author

ready for second pass - excluding up/down icon token tokens

@julauxen
Copy link
Collaborator

@SeamusLeonardHPE Second review done here.

@SeamusLeonardHPE
Copy link
Collaborator Author

Overlayed the updated verion here
One question remaining about component specific token for selected hover - Otherwise should be good to go

https://www.figma.com/design/5NUO23O2mDjiulO2H0S2Os/v2-Construction-Site?node-id=5144-43700&t=YRJSh2FHhPYv86dj-4

@julauxen
Copy link
Collaborator

hey @SeamusLeonardHPE Looks good, I am good to close it.

@SeamusLeonardHPE
Copy link
Collaborator Author

Closed as done - tracking token question issue in #4584

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SeamusLeonardHPE SeamusLeonardHPE

Labels
Phase:Current Sprint Used for issues that are being worked on current sprint.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SeamusLeonardHPE @julauxen