Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old version in README examples leads to errors #67

Open
ferm10n opened this issue May 18, 2023 · 1 comment
Open

Old version in README examples leads to errors #67

ferm10n opened this issue May 18, 2023 · 1 comment

Comments

@ferm10n
Copy link

ferm10n commented May 18, 2023

I got wrecked by #60 because I was using an old image (v1.6). It took me a while to realize that I just copied the example in the README, but the latest was at v2.0.

Maybe it'd be helpful to update the README, or setup something to update the README when a new package is released?

Or maybe even better, since there's specific k8s versions this package is compatible with, wait-for.sh could detect this and throw?

@tiljanssen
Copy link

Or just check whether the search for the active/succeeded/failed yielded any result, and if not, return an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants