Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient: add an error type to classify NACK errors #7863

Open
purnesh42H opened this issue Nov 21, 2024 · 0 comments
Open

xdsclient: add an error type to classify NACK errors #7863

purnesh42H opened this issue Nov 21, 2024 · 0 comments
Assignees
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Bug

Comments

@purnesh42H
Copy link
Contributor

Currently, when the xDS client encounters errors while decoding resources, the metadata indicates a NACKed update. However, the returned error lacks specific classification for these NACK errors. This makes it difficult to distinguish NACKs from other error types within the xdsresource package.

To enhance error handling, we should:

  • Introduce a New Error Type: Create a new error type, ErrTypeNack. This type should specifically represent NACKed updates.
  • Use xdsresource.NewErrorf: When setting the error field during an update after decoding, utilize xdsresource.NewErrorf to construct an error of type ErrNack.
@purnesh42H purnesh42H added Type: Bug Area: xDS Includes everything xDS related, including LB policies used with xDS. labels Nov 21, 2024
@purnesh42H purnesh42H self-assigned this Nov 21, 2024
@purnesh42H purnesh42H changed the title xdsclient: Add an error type to classify NACK errors xdsclient: add an error type to classify NACK errors Nov 21, 2024
@purnesh42H purnesh42H added the P2 label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: xDS Includes everything xDS related, including LB policies used with xDS. P2 Type: Bug
Projects
None yet
Development

No branches or pull requests

1 participant