New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GRPCCallOptions's retry property handling #49

Closed

dennycd opened this issue Jan 26, 2022 · 0 comments

Assignees

Labels

area/api area/objc-wrapper-client

Contributor

dennycd commented Jan 26, 2022 •

edited

Loading

On GRPCCallOptions, the following properties are currently not copied over

@Property(atomic, assign) NSTimeInterval maxRetryInterval;
@Property(atomic, assign) NSTimeInterval minRetryInterval;
@Property(atomic, assign) NSUInteger retryCount;
@Property(atomic, assign) double retryFactor;

In addition, these are currently marked readwrite on immutable option class GRPCCallOptions, and should be moved to GRPCMutableCallOptions instead.

dennycd added area/objc-wrapper-client area/api labels

dennycd self-assigned this

dennycd mentioned this issue

Patch GRPCCallOptions for missing property copy grpc/grpc#28696

Merged

dennycd closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment