Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deliver): skip upload screenshots #563

Merged

Conversation

2paperstar
Copy link
Member

@2paperstar 2paperstar commented Feb 18, 2025

애플이 API 안 고쳐줘서 일단 CI/CD 돌게 하려고 스크린샷 업로드를 비활성화 하였습니다

Summary by CodeRabbit

  • Chores
    • 앱 제출 시 스크린샷 업로드 단계가 생략되어 배포 프로세스가 간소화되었습니다.
    • 이번 업데이트는 내부 제출 작업 과정을 효율적으로 개선하여, 배포 속도와 안정성 향상에 기여합니다. 다만, 최종 사용자 경험에는 직접적인 변화가 없습니다.

Copy link
Contributor

coderabbitai bot commented Feb 18, 2025

📝 Walkthrough

Walkthrough

iOS 플랫폼의 production lane 내 Fastfile 파일에서 deliver 메서드 호출 시에 skip_screenshots: true 매개변수가 추가되었습니다. 이 변경은 앱 제출 과정에서 스크린샷 업로드 단계를 생략하도록 수정한 것으로, 제출 프로세스가 간소화됩니다.

Changes

파일 변경 요약
ios/fastlane/Fastfile production lane 내 deliver 호출에 skip_screenshots: true 매개변수 추가

Sequence Diagram(s)

sequenceDiagram
    participant 사용자 as 사용자
    participant ProdLane as production lane
    participant Deliver as deliver 메서드
    사용자->>ProdLane: 빌드 제출 요청
    ProdLane->>Deliver: deliver(..., skip_screenshots: true) 호출
    Deliver-->>ProdLane: 결과 반환
Loading

Poem

🐰 나는 토끼, 변화의 즐거움 담아
빠른 발걸음으로 새 길을 열어요.
스크린샷은 잠시 쉬어가고,
배포는 순조롭게 흘러가네.
작은 변화에도 마음이 춤추어요!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7978fbd and a098c30.

📒 Files selected for processing (1)
  • ios/fastlane/Fastfile (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build iOS App and Test
🔇 Additional comments (1)
ios/fastlane/Fastfile (1)

77-77:

❓ Verification inconclusive

스크린샷 업로드 건너뛰기 설정이 추가되었습니다.

변경사항이 적절해 보입니다. 스크린샷 업로드를 건너뛰는 것은 배포 프로세스를 최적화하는데 도움이 될 것 같습니다.

App Store 제출 과정에 문제가 없는지 확인해 주세요. 특히:

  1. 새로운 스크린샷이 필요한 경우가 아닌지
  2. 기존 스크린샷이 유지되는지

다음 명령어로 현재 App Store Connect의 스크린샷 상태를 확인할 수 있습니다:


🏁 Script executed:

#!/bin/bash
# App Store Connect의 스크린샷 상태 확인
bundle exec fastlane run get_app_store_connect_metadata

Length of output: 154


스크린샷 업로드 건너뛰기 옵션 검증 필요

변경사항인 skip_screenshots: true 추가는 fastlane의 deliver 옵션에 잘 부합하며, 배포 프로세스 최적화에 도움이 될 것으로 보입니다. 다만, 리뷰 코멘트에 포함된 아래 명령어 실행 시 오류가 발생했습니다:

bundle exec fastlane run get_app_store_connect_metadata

실행 결과:

+ bundle exec fastlane run get_app_store_connect_metadata
/.coderabbit_commands_2def8c26-a13d-4473-bf97-1246c405d15e.sh: line 3: bundle: command not found

따라서, 다음 사항을 확인해 주시기 바랍니다:

  • Bundler 설치 여부 확인: Fastlane 명령어를 실행하는 환경에서 Bundler가 설치되어 있어야 합니다.
  • 명령어 경로 및 실행 환경 점검: 올바른 환경에서 해당 명령어가 실행되고 있는지 확인해 주세요.
  • App Store 제출 과정 검증: 스크린샷 업로드 건너뛰기가 App Store 제출 과정에 영향을 미치지 않는지 수동으로 확인이 필요합니다.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@2paperstar 2paperstar requested a review from a team February 18, 2025 09:42
@2paperstar 2paperstar merged commit 8b7c362 into development Feb 19, 2025
5 checks passed
@2paperstar 2paperstar deleted the 510-cicd-deliver-doesnt-work-with-screenshot branch February 19, 2025 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant