-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Heroku request timeout #59
Comments
We get the same application error in an organization with 273 github users. |
@Nick-Smith has mentioned this issue as well - presumably you work together @prnewman ?! He said:
Sorry to hear about the problems you've been having. Nick's idea of parallelizing the audit by user sounds reasonable, the code you'd want to try changing would be: https://github.com/guardian/gu-who/blob/19d779dd16/app/lib/OrgSnapshot.scala#L111-L137 We have ~190 users and the job doesn't time out - usually the first run is the worst while all the GitHub calls are getting cached. We're also using a legacy Heroku dyno which may actually be better performing, but not an option for you: It will also run slower if there are lots of non-compliant users - we're in the happy position of having 100% compliance at the Guardian, so the check runs pretty fast. You may want to run gu:who locally on a laptop for a few days (getting the number of non-compliant users to decrease) before switching over to Heroku. I'm afraid @lindseydew & I are pretty busy right now, we haven't much time for maintenance on gu:who! |
@rtyley Thanks for the feedback. I'll update if things change as more users comply. This hiccup notwithstanding, gu:who has been extremely helpful. Thank you! |
In my case the app always times out with this message on the page:
The logs are ok, the actual audit is successful and all the issues are created/updated.
The timeout is 30 sec and according to docs it is not configurable.
The solution is to serve page first and then dynamically serve results.
Or at least start sending the static page heading and once the results are ready finish sending the page - it would increase the timeout by 55 sec.
The text was updated successfully, but these errors were encountered: