Incorrect names for enum values

[OlegYch]

For a enum like this

"enum": [
                "datetime",
                "-datetime"
              ]

guardrail will generate two objects with same name Datetime

[blast-hardcheese]

@OlegYch Interesting, thank you for reporting!

This scales, unfortunately, "--datetime" etc, so coming up with useful names to disambiguate is going to be tricky.

Reaching out to the JVM for a universal solution here seems the way to completely solve this problem, at the expense of the names it would generate:

scala> java.lang.Character.getName('-')
val res0: String = HYPHEN-MINUS

scala> java.lang.Character.getName('/')
val res1: String = SOLIDUS

scala> java.lang.Character.getName('\\')
val res2: String = REVERSE SOLIDUS

At the very least they'd be unique, and we'd only need to interpolate them in the case of disambiguation, so maybe it's alright that the names are not good.

What do you think?

[OlegYch]

i think the usual quoting is enough, eg:

case object Datetime
case object `-datetime`

[blast-hardcheese]

Possibly in Scala, but Java will have this problem. I guess we could do both, each language having their own experience.

[OlegYch]

Oh, perhaps it's possible to borrow name mangling scheme from scala.

…

On Thu, Mar 7, 2024, 23:22 Devon Stewart ***@***.***> wrote: Possibly in Scala, but Java will have this problem. I guess we could do both, each language having their own experience. — Reply to this email directly, view it on GitHub <#1958 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACBQGBUPSPG26QP3OQV4V3YXDSDPAVCNFSM6AAAAABELERPTGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBUGYZDONJVGM> . You are receiving this because you were mentioned.Message ID: ***@***.***>