You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.
Calling Conn.Close() multiple time right now crashes with a panic when closing the out channel multiple times. It is typically good form to close a connection when its not used anymore, but the above makes that unsafe, because there are internal callers to Close() that you can't control (for instance on a socket read error due to a remote close). Since those happen in another thread its basically impossible to propely know if closing is safe.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Calling Conn.Close() multiple time right now crashes with a panic when closing the out channel multiple times. It is typically good form to close a connection when its not used anymore, but the above makes that unsafe, because there are internal callers to Close() that you can't control (for instance on a socket read error due to a remote close). Since those happen in another thread its basically impossible to propely know if closing is safe.
The text was updated successfully, but these errors were encountered: