Skip to content
This repository has been archived by the owner on Jan 6, 2022. It is now read-only.

Should allow multiple calls to Conn.Close() #47

Open
alexlarsson opened this issue Dec 10, 2013 · 0 comments
Open

Should allow multiple calls to Conn.Close() #47

alexlarsson opened this issue Dec 10, 2013 · 0 comments

Comments

@alexlarsson
Copy link

Calling Conn.Close() multiple time right now crashes with a panic when closing the out channel multiple times. It is typically good form to close a connection when its not used anymore, but the above makes that unsafe, because there are internal callers to Close() that you can't control (for instance on a socket read error due to a remote close). Since those happen in another thread its basically impossible to propely know if closing is safe.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant