Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add column for git sha or version tag #46

Open
anoop2811 opened this issue Jan 22, 2024 · 4 comments
Open

Feat: Add column for git sha or version tag #46

anoop2811 opened this issue Jan 22, 2024 · 4 comments
Assignees

Comments

@anoop2811
Copy link
Contributor

As a developer,
When I run my tests,
And use fern for reporting,
And have committed changes
Then the git sha should be a tag or a column in the report

For unpushed change,
We need to make a decision on what to show. Maybe as a "dirty" as we have no way to referring back to the changes if the commit is not pushed or if the files are not committed in the first place

@anoop2811 anoop2811 added this to the FernReporter-v1.0.0 milestone Jan 22, 2024
@jjchambl
Copy link
Collaborator

Either a "dirty" or "local" grouping makes the most sense, as I don't think there's a way to do this outside of manual testing on a local machine.

Is there a way to manage/remove these? Over time I can see this list potentially becoming large if developers continue to push local tests.

@anoop2811
Copy link
Contributor Author

Thats a good point @jjchambl about large number of local tests. I think we need to evolve this such that we can configure the server to be using a flag to accept a dirty report or not. That way if people want to use for local tests, they can run the fern-reporter locally with --dirty-enabled or something like that so that it would accept those type of reports

@Swathi-L
Copy link
Contributor

I'm planning to work on this, confirming no one else is already taking a look at it.

@anoop2811
Copy link
Contributor Author

All yours @Swathi-L

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants