Skip to content
This repository has been archived by the owner on Sep 18, 2020. It is now read-only.

Merge params and queryParams #1

Open
guilhermeaiolfi opened this issue Mar 19, 2015 · 2 comments
Open

Merge params and queryParams #1

guilhermeaiolfi opened this issue Mar 19, 2015 · 2 comments

Comments

@guilhermeaiolfi
Copy link
Owner

In the enter hood merge params like:

var params = jQuery.extend(ctx.transition.routes.queryParams, current_route.params);

jQuery is already available. But maybe lodash should be considered.

@silentworks
Copy link

I saw this and was wondering why not use lodash _.deepClone method instead? I might not have/want jQuery in my project at all.

@guilhermeaiolfi
Copy link
Owner Author

Yes. Using _.deepClone there and remove the jQuery.on/off`` for thehashchange``` event we could remove the jQuery dep.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants