-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make S3M's conflicts wrap only the conflicting lines #101
Comments
@jvcoutinho what about when there is a conflict in the body too? aren't the body conflicts add too much noise to the merge results? |
This would only "shrink" the merge conflict, eliminating common parts at the edge. For example, in the following scenario: LEFT
BASE
LEFT
Unstructured merge outputs this:
Meanwhile, semistructured merge + renaming handler output this:
With this change, it would output this:
|
Interesting, the unstructured merge output is totally accurate in terms of marking only the conflicting changes. However between default semistructured and the proposed change, for me, default is better: why |
Currently, S3M's conflicts wrap all of a node's content inside the conflict text. So, in this scenario:
BASE
LEFT
RIGHT
(That means, left and right renamed the same method to different signatures.)
The merge result is:
instead of:
This is only an enhancement to a more elegant (and concise) conflict text.
The text was updated successfully, but these errors were encountered: