Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming handlers for other kinds of declarations #48

Open
pauloborba opened this issue Sep 24, 2018 · 4 comments
Open

Renaming handlers for other kinds of declarations #48

pauloborba opened this issue Sep 24, 2018 · 4 comments
Assignees

Comments

@pauloborba
Copy link
Collaborator

Field declarations would only be relevant in case of multiple lines field declarations, otherwise unstructured and semistructured merge report the same conflicts (we have talked about this long time ago). Entire files are handled reporting the same result of unstructured merge, also discussed long time ago. Finally, innerclasses are handled by other handler (DeletionsHandler).

we should empirically confirm that. enums might be a target.

@guilhermejccavalcanti
Copy link
Owner

Let's enumerate the possible cases, and how it works currently:

@pauloborba
Copy link
Collaborator Author

@jvcoutinho we should integrate alice's version (initialization handler), and discuss what to do with the other kinds of declarations

@jvcoutinho
Copy link
Collaborator

Will she create a pull request?

@pauloborba
Copy link
Collaborator Author

@jvcoutinho check if alice's version is specific to static block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants