Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis build considering different OS #68

Closed
pauloborba opened this issue Nov 7, 2018 · 7 comments · Fixed by #96
Closed

Travis build considering different OS #68

pauloborba opened this issue Nov 7, 2018 · 7 comments · Fixed by #96
Assignees

Comments

@pauloborba
Copy link
Collaborator

No description provided.

@jvcoutinho
Copy link
Collaborator

@pauloborba @guilhermejccavalcanti, I have to modify the shell tests to setup Travis for Windows. I think this is a good opportunity to eliminate them. I can rewrite them as JUnit tests and maintain at least the Git integration test for the installer. Do you agree with that?

@jvcoutinho jvcoutinho self-assigned this Aug 13, 2019
@jvcoutinho
Copy link
Collaborator

Also, probably it's worth to solve #87 in order to setup Travis for Mac OS, since git lfs is not installed by default and the build is crashing because of that.

@pauloborba
Copy link
Collaborator Author

Also, probably it's worth to solve #87 in order to setup Travis for Mac OS, since git lfs is not installed by default and the build is crashing because of that.

makes sense to me

@pauloborba
Copy link
Collaborator Author

@pauloborba @guilhermejccavalcanti, I have to modify the shell tests to setup Travis for Windows. I think this is a good opportunity to eliminate them. I can rewrite them as JUnit tests and maintain at least the Git integration test for the installer. Do you agree with that?

OK, provided the semantics is the same.

@pauloborba
Copy link
Collaborator Author

but they should be invoked by the installer. so that we still have tests for the development team, and tests to the users (system testing)---to make sure that the tool was properly installed in their environment.

@pauloborba
Copy link
Collaborator Author

@guilhermejccavalcanti can we accept the associated PR and close the issue?

@guilhermejccavalcanti
Copy link
Owner

guilhermejccavalcanti commented Sep 14, 2019

@jvcoutinho there are still merge conflicts, so I cannot merge the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants