add SVG.py #28
Closed
add SVG.py #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yuiseki
import shogi
board = shogi.Board()
print(board.svg()) |
|
I pulled yuiseki's branch and didn't have the same problem as you (pieces were loading! - not all though). I forked the project and managed to get it to work Default Board (as in your example)
SFEN ('4+R3l/1r1+P2gk1/3p1p1s1/2pg3pp/1p4p2/SP4PPP/2NP1PKS1/2G2+n3/8L w B2N2L3Pbgsp 10')
I can open a new pull request if you like to see! |
|
@DerAndereJohannes |
|
Looks Nice! Sorry for my half-baked contribution |
I did not do much to your code! You set it up very nicely! 😁👍 You can check it out in the other pull request! |
|
Close this pull request because of #36 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Content
./shogi/SVG.py../shogi/__init__.pyto appendboard.svg()method.README.rstto introduceboard.svg()method.How To Check
$ python>>> import shogi>>> board = shogi.Board()>>> board.svg()should output SVG text.Others