-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Rust's ndarray library more efficiently in the interpreter #8
Comments
@hypercubestart This one mostly involves taking a look at the ndarray library and using it more efficiently. I don't have a lot of good guidance here; we can talk in more detail later. Basically, this task involves getting to understand the library and how it works, and using it "more correctly" in Glenside. Specifically, avoiding data copies wherever possible! |
@hypercubestart Please add your notes on this whenever you can! Would like to document all of the issues we had before we move on to something else. |
crossposting from #59: on hold for now...because of difficulty of getting lifetimes to work out. Ideally, we could use ArrayViews that reference owned arrays already in the hashmap, but Rust lifetimes don't permit this
|
Thanks, sorry I didn't see that comment!! Many open issues and PRs haha |
We use ndarray as our tensor representation, but we don't use it very efficiently. Specifically, we copy data everywhere, for nearly every operation. The ndarray library is smart; it can do many of the operations we need to do without copying data, if only we understood how to use it well. There are also opportunities to contribute back to ndarray, if we find something we'd like to be able to do that they haven't yet implemented. From what little I've dug in their source code already, it seems like these opportunities might be abundant, and contributing shouldn't be too hard!
The text was updated successfully, but these errors were encountered: