Optimizing with plugin fails due to asynchronous load

[purge]

rjs 2.1.9 seems to be stricter about this, as such any asynchronous calls to onload will fail now. See 'build considerations' in http://requirejs.org/docs/plugins.html

[zxekak]

@purge do you mean error like Error: Loader plugin did not call the load callback in the build: require-less/less?

[purge]

Yes, thats the one.

On Wed, Oct 23, 2013 at 9:58 AM, zxekak [email protected] wrote:

@purge https://github.com/purge do you mean error like Error: Loader
plugin did not call the load callback in the build: require-less/less?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/33#issuecomment-26889694
.

[guybedford]

Thanks for the help with testing. Are you sure you got that exact message though?

There were some changes in the 1.5.0 release that weren't caught in the 1.5.0-b4 release this was tested on originally.

It is now updated to work with the latest less 1.5.0 release, and this should be resolved.

[guybedford]

Argh actually this is a RequireJS 2.1.9 issue... working on it...

[guybedford]

Ok, this has been fixed now. Ready for a 0.1 release now, pending a little more testing.

[guybedford]

This should be fixed in the new 0.1.0 release. Let me know if it isn't.

[Mamuuut]

I get the same error message with r.js 2.1.10 with the require-less example

Tracing dependencies for: core-components
[object Object] at components/component.less, line 1
Error: Error: Loader plugin did not call the load callback in the build:
less/less:
less/less!components/component: [object Object]
Module loading did not complete for: components/component

[Mamuuut]

It seems that the less parser error is an object and not a string.
In order to display the error message properly, err.message should be used.

console.log(err.message + ' at ' + path.relative(baseUrl, err.filename) + ', line ' + err.line);
return load.error(new Error(err.message));

I still don't understand why I get a 'Syntax Error on line 1' error message from the parser ...

[Mamuuut]

OK, I just forgot to update my less npm package...
Maybe a compatibility check on less.version could help.

[guybedford]

Thanks that is great to bear in mind for issues in future. That could certainly be a good way to protect against this - I've created an issue here: #59.