Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to archive protest #89

Open
guytepper opened this issue Oct 10, 2020 · 1 comment
Open

Add option to archive protest #89

guytepper opened this issue Oct 10, 2020 · 1 comment
Labels

Comments

@guytepper
Copy link
Owner

Currently, the way we remove protests is by deleting them from the collection.
It's better if we add an archived property to it instead. It'll require changes across all source code (wherever we fetch protests we need to add an archived != true condition to it.
We'll probably need to add a migration that adds the archived property to all existing protests (it'll make it easier to run conditions on the collection).

@daganomri
Copy link
Contributor

I believe that in the current admin flow what you're describing already happens. You can archive an approved protest and it adds to it archived: true. All that remains is to filter it out on our api requests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants