-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading dependencies causes smokey to fail #285
Comments
Hi @paul-snively 👋🏽 I'll have a look, that looks a lot like a bug in |
I download the patch for #289 and applied it to my fork of your Do you have some information about what the bug was, and where/how it was resolved? Thanks so much! |
@paul-snively I haven't upgraded |
@paul-snively looks like #290 fixed it. Let me know if that works for you. |
Yep, patch applies cleanly on top of #289 applied to Thanks so much! |
I've forked this project. My fork can be found here.
I've tried to limit myself to upgrading the Scala 3 version to the LTS version, and upgrading the core dependencies to their latest versions supporting Scala 3. In terms of source code changes, this has been completely trivial.
However, when I stand everything up and run
sbt smoke
, the test fails due to a websocket connection timing out, and several of the expected messages not being received.Doing the same with the original code passes using the same JVM on the same host.
Looking at the evolving dependencies, my biggest concern is the changes to the http4s JDK client used for websocket support. It appears to have undergone significant revision from M6 to M7, revolving around new cats-effect capabilities. However, neither reverting to M6 (the last version in which
simple
returns aResource
) and M3 (the version used in the original code) solves the problem. Nevertheless, the finicky-looking nature of the websocket client with respect to state and lifecycles continues to make me nervous.Any suggestions would be greatly appreciated.
The text was updated successfully, but these errors were encountered: