Support JDT's implicit yield in switch statements #10100
+56
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDT generates a yield for arrow cases if the arrow points at a expression, even though the expression cannot be returned. Synthesize a block wrapping that expression as a statement, and add a break to the end of it. Fixes gwtproject#10044
zbynek
reviewed
Feb 26, 2025
| @@ -121,6 +121,9 @@ public void testSwitchExprInlining() { | |||
| public void testInlinedStringConstantsInCase() { | |||
| assertFalse(isGwtSourceLevel17()); | |||
| } | |||
| public void testCaseArrowLabelsVoidExpression() { | |||
There was a problem hiding this comment.
Also missing in main (this is a backport for 2.12.2), so I'm somewhat unconcerned.
Related-ish, I will put up a PR soon that might get our checkstyle annotations back, again, in PRs...
vegegoku
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JDT generates a yield for arrow cases if the arrow points at a expression, even though the expression cannot be returned. Synthesize a block wrapping that expression as a statement, and add a break to the end of it.
Fixes #10044
See #10059