From 843bfd6199efe2496b41c161b31caeb692a1f36b Mon Sep 17 00:00:00 2001
From: Pauline Vidal <pauline.vidal@ipp.mpg.de>
Date: Tue, 22 Oct 2024 16:36:56 +0200
Subject: [PATCH] Mistakes in PredCorr in geometryRTheta

A typo in the comment and mixing two advection fields in the `bs_predcorr_second_order_explicit.hpp` file.

See merge request gysela-developpers/gyselalibxx!739

--------------------------------------------
---
 .../bsl_predcorr_second_order_explicit.hpp            | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/src/geometryRTheta/time_solver/bsl_predcorr_second_order_explicit.hpp b/src/geometryRTheta/time_solver/bsl_predcorr_second_order_explicit.hpp
index 143462a72..b715c8e15 100644
--- a/src/geometryRTheta/time_solver/bsl_predcorr_second_order_explicit.hpp
+++ b/src/geometryRTheta/time_solver/bsl_predcorr_second_order_explicit.hpp
@@ -133,17 +133,16 @@ class BslExplicitPredCorrRTheta : public ITimeSolverRTheta
     }
 
 
-    ~BslExplicitPredCorrRTheta() {};
+    ~BslExplicitPredCorrRTheta() override {}
 
 
 
     host_t<DFieldRTheta> operator()(
             host_t<DFieldRTheta> allfdistribu,
             double const dt,
-            int const steps) const
+            int const steps) const final
     {
-        std::chrono::time_point<std::chrono::system_clock> start_time
-                = std::chrono::system_clock::now();
+        std::chrono::time_point<std::chrono::system_clock> start_time;
         std::chrono::time_point<std::chrono::system_clock> end_time;
 
         // Grid. ------------------------------------------------------------------------------------------
@@ -223,7 +222,7 @@ class BslExplicitPredCorrRTheta : public ITimeSolverRTheta
 
 
             // STEP 4: From rho^P, we compute phi^P: Poisson equation
-            m_builder(get_field(allfdistribu_coef), get_const_field(allfdistribu));
+            m_builder(get_field(allfdistribu_coef), get_const_field(allfdistribu_predicted));
             PoissonLikeRHSFunction const
                     charge_density_coord_4(get_const_field(allfdistribu_coef), m_evaluator);
             m_poisson_solver(charge_density_coord_4, electrostatic_potential_coef);
@@ -232,7 +231,7 @@ class BslExplicitPredCorrRTheta : public ITimeSolverRTheta
             advection_field_computer(electrostatic_potential_coef, advection_field_predicted);
 
 
-            // ---  we evaluate the advection field A^n at the characteristic feet X^Theta
+            // ---  we evaluate the advection field A^n at the characteristic feet X^P
             host_t<DVectorFieldMemRTheta<X, Y>> advection_field_evaluated(grid);
             host_t<VectorSplineCoeffsMem2D<X, Y>> advection_field_coefs(
                     get_spline_idx_range(m_builder));