Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translations not built / installed for the latest commit(s) #606

Open
L-U-T-i opened this issue Oct 7, 2024 · 0 comments · May be fixed by #607
Open

Translations not built / installed for the latest commit(s) #606

L-U-T-i opened this issue Oct 7, 2024 · 0 comments · May be fixed by #607
Assignees
@Abestanis
Labels
bug Something isn't working

Comments

@L-U-T-i
Copy link

L-U-T-i commented Oct 7, 2024

OS:
Rocky Linux 9.4

Linux Desktop Manager:
Mate Desktop 1.28

Birdtray version:
1.12.4 (latest git commit 28bb44b)

Thunderbird version:
128.3.0esr

Birdtray origin:
From source (custom build)

Qt version: NA
6.6.2

Description

Translations are not built with the current `CMakeLists.txt`.

Expected behavior

Translations are built and installed as before (qt5).

To Reproduce

  1. Build the package.

Additional context

I've had to add the following CMakeLists.txt modifications to successfully build birdtray (as before for Qt5):

sed -i 's/Qt5LinguistTools/Qt6LinguistTools/g' CMakeLists.txt
sed -i 's/qt5_/qt6_/g' CMakeLists.txt

BTW, I've also modified src/birdtrayapp.cpp to get rid of the deprecation warning:
sed -i 's/QLibraryInfo::location/QLibraryInfo::path/g' src/birdtrayapp.cpp
and haven't noticed any negative consequences by now (birdtray installed and running without complains).
@L-U-T-i L-U-T-i added the bug Something isn't working label Oct 7, 2024
@Abestanis Abestanis self-assigned this Oct 7, 2024
@Abestanis Abestanis linked a pull request Oct 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Abestanis Abestanis

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix building the translations Abestanis/birdtray
2 participants
@Abestanis @L-U-T-i