Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend Improvements #1

Open
wants to merge 7 commits into
base: devel
Choose a base branch
from
Open

Frontend Improvements #1

wants to merge 7 commits into from

Conversation

furkansimsekli
Copy link
Member

@furkansimsekli furkansimsekli commented Feb 19, 2023

Content page:

  • Content box
  • Font
  • Content header adjustments

Index page:

  • Index Page

Description: Content title should be decided in Markdown text itself.
Using file name as the content title can be tricky in long term, because
sometimes we may need more than one content title since the contents don't need
to be plain and simple like current ones. That's why using `title` variable as
head title seems more convenient.
@furkansimsekli furkansimsekli marked this pull request as draft February 19, 2023 10:53
@furkansimsekli furkansimsekli requested a review from div72 February 19, 2023 10:53
@furkansimsekli
Copy link
Member Author

furkansimsekli commented Apr 2, 2023

I decided not to include dark/light mode switch in this PR.

Currently, headers are not being used correctly. I fixed that setting the tab title with title and rest of it up to Markdown document. Note that #'s are centered for a better view. This change breaks the compatibility with older documents but updating them shouldn't be hard.

What do you think about Fonts? In this PR, I used IBM Plex Sans from Google, you said "no" even though it's Open Font Licensed. @div72 So, feel free to change it.

@furkansimsekli furkansimsekli marked this pull request as ready for review April 2, 2023 05:39
@furkansimsekli
Copy link
Member Author

furkansimsekli commented Apr 12, 2023

Fixed overflow problems for images.

Also discovered that we can use html trick to center images and set their width/height manually. This can be used in Markdown when authors want to insert an image:

<p align="center">
  <img src="" width="">
</p>

Preview:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant