-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Shift schedule page #69
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please notice that getting the data will change drastically once we move this onto using a database.
Also, merge the dev branch into yours so we get all the new CI checks here as well.
Good job :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
One thing I also forgot to mention is that there may be some missing aria labels, so if you have any interactive elements (buttons, links etc...) that does somehting and the text in the element is not descriptive enough it may be smart to add an aria-label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're getting very close to this being ready.
There are some quirks when using conditionals in React, so it may be useful to take a look at https://react.dev/learn/conditional-rendering, especially the part about the &&
operator.
The solution for getting timestamps in ScheduleTable
is quite wordy (even though it is the least wordy version of that approach), but I don't think there is any way to get that even cleaner, as least not without using some kind of additonal library for dates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I've made some progress on the front-end of the shift-schedule page, issue #34. The shift schedule table displays how many members are on shift for every day and time, and when pressing one of the shifts you can see who's on shift and have the option to register for it. There is also an administrator menu where members with the correct permission would be able to clear the shift schedule.
Changes before issue can be closed:
Create Icons for skills and link them to skills from the DB #63