-
-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition From Downloaded to Importing Fonts #1333
Comments
@plang-psm This sounds cool, what would this improve (it will make the website faster, improve user experience, etc.)? |
Hi @hollydo thanks for taking on this issue! (super small request) In the future, if you assign yourself to an issue, please also be sure to change the status to "In Progress". I went ahead and made that change for ya |
Thanks Jack! Sorry I forgot to move it to the "In Progress" column. |
@JackHaeg I've finished this ticket, but I am not sure how to access the admin dashboard to check if the Source Code Pro font haven't changed after transitioning over to using imported fonts instead of downloaded ones. I did checked that the fonts are working by creating a h2 on the login page with the same class using Source Code Pro font and it's working. Also, I could not find aliseo-noncommercial font hosted by google. So I think we'll still need to keep and use the downloaded font. |
@trillium Given Holly's feedback, should we just keep and use the downloaded font, or can you provide any additional feedback to resolve this issue? I don't believe this was a hard requirement to switch to imported fonts instead of downloaded ones, but let me know what you think. If we are just going to keep the downloaded fonts, then we can close this issue as unplanned. |
@JackHaeg the Source Code Pro fonts are hosted on google, and we were already importing it from there. I just had to changed some classes, to use those imported fonts instead of the downloaded ones. I just couldn't find the aliseo font hosted online. |
Ah, I see - I also could not find the aliseo font on Google Fonts (of course, there is the download available for personal use here, but I don't believe that's what we are looking for). @trillium Would you suggest Holly submit a PR with these changes and we continue using the downloaded aliseo font for the time being? |
Overview
We need to transition from downloading and storing fonts in the
src/fonts
folder to simply importing them from Google fonts.Action Items
src/fonts
folder.@font-face
with Google fonts using the@import url()
method.@import url()
, delete thesrc/fonts
folder.Resources/Instructions
https://fonts.google.com/
https://stackoverflow.com/questions/14676613/how-to-import-google-web-font-in-css-file
The text was updated successfully, but these errors were encountered: