Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition From Downloaded to Importing Fonts #1333

Open
4 tasks
plang-psm opened this issue Mar 13, 2023 · 9 comments · May be fixed by #1864
Open
4 tasks

Transition From Downloaded to Importing Fonts #1333

plang-psm opened this issue Mar 13, 2023 · 9 comments · May be fixed by #1864
Assignees
Labels
complexity: small feature: Infrastructure Secrets, Prod and Dev setup, etc. role: Front End size: 0.5pt Can be done in 2-3 hours or less

Comments

@plang-psm
Copy link
Member

plang-psm commented Mar 13, 2023

Overview

We need to transition from downloading and storing fonts in the src/fonts folder to simply importing them from Google fonts.

Action Items

  • Research what fonts, and font weights are currently downloaded and stored in the src/fonts folder.
  • In the index.scss, replace the @font-face with Google fonts using the @import url() method.
  • Once all fonts are passed via the @import url(), delete the src/fonts folder.
  • Test the app and see if the correct fonts are being passed.

Resources/Instructions

https://fonts.google.com/
https://stackoverflow.com/questions/14676613/how-to-import-google-web-font-in-css-file

@JackHaeg
Copy link
Member

JackHaeg commented Jul 20, 2023

@plang-psm This sounds cool, what would this improve (it will make the website faster, improve user experience, etc.)?

@JackHaeg JackHaeg added this to the Y - Excellent Level milestone Aug 10, 2023
@JackHaeg JackHaeg added feature: Infrastructure Secrets, Prod and Dev setup, etc. and removed p-feature: Projects labels Feb 1, 2024
@JackHaeg JackHaeg moved this to Icebox in P: VRMS: Project Board Jun 13, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this from Icebox to New Issue Approval in P: VRMS: Project Board Jul 16, 2024
@hollydo hollydo self-assigned this Feb 11, 2025
@JackHaeg JackHaeg moved this from Prioritized Backlog to In progress in P: VRMS: Project Board Feb 13, 2025
@JackHaeg
Copy link
Member

Hi @hollydo thanks for taking on this issue! (super small request) In the future, if you assign yourself to an issue, please also be sure to change the status to "In Progress". I went ahead and made that change for ya

@hollydo
Copy link
Contributor

hollydo commented Feb 14, 2025

Thanks Jack! Sorry I forgot to move it to the "In Progress" column.

@hollydo
Copy link
Contributor

hollydo commented Feb 17, 2025

@JackHaeg I've finished this ticket, but I am not sure how to access the admin dashboard to check if the Source Code Pro font haven't changed after transitioning over to using imported fonts instead of downloaded ones. I did checked that the fonts are working by creating a h2 on the login page with the same class using Source Code Pro font and it's working.

Also, I could not find aliseo-noncommercial font hosted by google. So I think we'll still need to keep and use the downloaded font.

@JackHaeg
Copy link
Member

@trillium Given Holly's feedback, should we just keep and use the downloaded font, or can you provide any additional feedback to resolve this issue?

I don't believe this was a hard requirement to switch to imported fonts instead of downloaded ones, but let me know what you think. If we are just going to keep the downloaded fonts, then we can close this issue as unplanned.

@hollydo
Copy link
Contributor

hollydo commented Feb 17, 2025

@JackHaeg the Source Code Pro fonts are hosted on google, and we were already importing it from there. I just had to changed some classes, to use those imported fonts instead of the downloaded ones. I just couldn't find the aliseo font hosted online.

@JackHaeg
Copy link
Member

JackHaeg commented Feb 17, 2025

Ah, I see - I also could not find the aliseo font on Google Fonts (of course, there is the download available for personal use here, but I don't believe that's what we are looking for). @trillium Would you suggest Holly submit a PR with these changes and we continue using the downloaded aliseo font for the time being?

@JackHaeg
Copy link
Member

@hollydo Just spoke with @trillium about this - please go ahead and submit a PR with your changes. We will continue to use the downloaded aliseo font for now.

@hollydo hollydo linked a pull request Feb 22, 2025 that will close this issue
@hollydo
Copy link
Contributor

hollydo commented Feb 22, 2025

Thank you @JackHaeg for the update. I've opened a PR for this issue at #1864

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity: small feature: Infrastructure Secrets, Prod and Dev setup, etc. role: Front End size: 0.5pt Can be done in 2-3 hours or less
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

4 participants