Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Pull Request Template #1383

Closed
1 task
sydneywalcoff opened this issue May 4, 2024 · 1 comment · Fixed by #1607
Closed
1 task

Create Pull Request Template #1383

sydneywalcoff opened this issue May 4, 2024 · 1 comment · Fixed by #1607
Assignees
@sydneywalcoff
Labels
DevOps type of development task related to Process, Github Actions, and Deployment feature: dev workflow issue level I: request Smallest type of issue; Typically can be completed by one person priority: low role: development anything related to code size: 1pt can be done in 6 hours or less
Milestone
06. Team Workflow

Comments

@sydneywalcoff
Copy link
Member

sydneywalcoff commented May 4, 2024 •
edited
Loading

Overview

The team has established an outline for what PRs should look like. To make the PR process more efficient, we'd like to translate that outline to a PR template.

title: [ISSUE_NUMBER] - [DESCRIPTION]

--------

Fixes #ISSUE_NUMBER

### Changes Made


### Reason for Changes


### Screenshots (if needed)
#### before


#### after


### Action Items
- [ ] review PR files to guarantee ONLY relevant code is present
- [ ] add https://github.com/hackforla/expunge-assist/labels/ready%20for%20dev%20lead label

Action Items

  • use the information above to create a PR template

Resources/Notes

Github PR Template Docs
@sydneywalcoff sydneywalcoff added role: development anything related to code priority: low size: 1pt can be done in 6 hours or less DevOps type of development task related to Process, Github Actions, and Deployment feature: dev workflow issue level I: request Smallest type of issue; Typically can be completed by one person labels May 4, 2024
@sydneywalcoff sydneywalcoff added this to the Team Workflow milestone May 4, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this to Prioritized Backlog in P: EA: Project Board Jun 14, 2024
@sydneywalcoff sydneywalcoff self-assigned this Oct 9, 2024
@sydneywalcoff sydneywalcoff moved this from Prioritized Backlog to In Progress (active) in P: EA: Project Board Oct 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 9, 2024

Hey @sydneywalcoff! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

sydneywalcoff added a commit that referenced this issue Oct 9, 2024
@sydneywalcoff
#1383 - pull request template
dd78074
@sydneywalcoff sydneywalcoff mentioned this issue Oct 9, 2024
Merged
3 tasks
sydneywalcoff added a commit that referenced this issue Oct 9, 2024
@sydneywalcoff
Merge pull request #1606 from hackforla/1383-pr-template
a69408d 
#1383 - pull request template
@sydneywalcoff sydneywalcoff mentioned this issue Oct 9, 2024
Merged
@github-project-automation github-project-automation bot moved this from In Progress (active) to Done in P: EA: Project Board Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sydneywalcoff sydneywalcoff

Labels
DevOps type of development task related to Process, Github Actions, and Deployment feature: dev workflow issue level I: request Smallest type of issue; Typically can be completed by one person priority: low role: development anything related to code size: 1pt can be done in 6 hours or less
Projects
P: EA: Project Board
Status: Done
Milestone
06. Team Workflow
Development

Successfully merging a pull request may close this issue.

Dev hackforla/expunge-assist
1 participant
@sydneywalcoff