Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Welcome page background back to #F7EBFF on mobile #1564

Closed
1 task done
eburdekin opened this issue Sep 24, 2024 · 3 comments
Closed
1 task done

Change Welcome page background back to #F7EBFF on mobile #1564

eburdekin opened this issue Sep 24, 2024 · 3 comments
Assignees
@anitadesigns
Labels
issue level I: request Smallest type of issue; Typically can be completed by one person p-feature: Welcome https://expungeassist.org/welcome priority: low role: design anything related to design size: 1pt can be done in 6 hours or less
Milestone
00. Stakeholder R...

Comments

@eburdekin
Copy link
Member

eburdekin commented Sep 24, 2024 •
edited by anitadesigns
Loading

Overview

We recently updated the background for the Welcome page from '#F7EBFF' to '#FFFFFF' across devices, but upon reviewing the Figma designs, it should have stayed '#F7EBFF' on mobile.

Currently live Figma wireframes
Desktop (correct) Screen Shot 2024-09-23 at 7 28 15 PM Screen Shot 2024-09-23 at 7 25 31 PM
Mobile (incorrect) Screen Shot 2024-09-23 at 7 30 23 PM Screen Shot 2024-09-23 at 7 27 12 PM

Action Items

  • Update styling for Welcome page on mobile - can probably reuse/update the useEffect that was removed with the previous branch here

Resources/Notes
@github-project-automation github-project-automation bot moved this to New Issues for approval in P: EA: Project Board Sep 24, 2024
@eburdekin eburdekin added this to the Stakeholder Review 2.0 milestone Sep 24, 2024
@eburdekin eburdekin added role: development anything related to code priority: low size: 1pt can be done in 6 hours or less p-feature: Welcome https://expungeassist.org/welcome issue level I: request Smallest type of issue; Typically can be completed by one person ready for design lead and removed role: missing size: missing feature: missing priority: missing issue level: missing This issue is missing an issue level label labels Sep 24, 2024
@mariaweissman mariaweissman mentioned this issue Oct 1, 2024
Open
@anitadesigns
Copy link
Member

Thanks for catching this @eburdekin ! This is a detail that fell through the cracks where Design forgot to update the background on the mobile wireframes. Everything on the website is correct!

@sydneywalcoff Im going to change the role to Design so we can take care of it

@anitadesigns anitadesigns added role: design anything related to design and removed role: development anything related to code ready for design lead labels Oct 4, 2024
@anitadesigns anitadesigns self-assigned this Oct 17, 2024
@github-actions GitHub Actions
Copy link

Hey @anitadesigns! Thanks for taking this issue.

To help keep everyone in the loop, please comment your Estimated Time to Completion (ETC) below!

Thanks again!

@anitadesigns
Copy link
Member

Design updated the mobile wireframe's background color to white!

@github-project-automation github-project-automation bot moved this from In Progress (active) to Done in P: EA: Project Board Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anitadesigns anitadesigns

Labels
issue level I: request Smallest type of issue; Typically can be completed by one person p-feature: Welcome https://expungeassist.org/welcome priority: low role: design anything related to design size: 1pt can be done in 6 hours or less
Projects
P: EA: Project Board
Status: Done
Milestone
00. Stakeholder Review 2.0
Development

No branches or pull requests
2 participants
@anitadesigns @eburdekin