-
-
Notifications
You must be signed in to change notification settings - Fork 777
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Docker file to be multi-platform #6269
Comments
This comment was marked as outdated.
This comment was marked as outdated.
@fyliu could you kindly review this issue? Also would it be appropriate for me to use your https://github.com/hackforla/docker-mkdocs/blob/main/.github/workflows/build-image.yml as a reference? |
@roslynwythe Maybe my workflow file could serve as an example? I have a question: do you know if PRs made from a fork is able to run workflows in the main repo? I'm guessing no, because it feels like a security risk if it did. I know that PRs from same repo branches are able to run workflows with the repo secrets, so that someone making a PR with the workflow file tagging Anyway, the issue is that dockerhub credentials in github secrets wouldn't replicate over when forking the repo. What I did was
That allowed my fork's workflow to push the images to my personal dockerhub repo for testing. I didn't have to change the image tag since it's a different dockerhub repo. |
This comment was marked as outdated.
This comment was marked as outdated.
This issue will have to have a second developer assigned after the first person does the work, so that they can test it in the environment the other developer does not have. That needs to be mentioned in the instructions. |
@ExperimentsInHonesty I updated the Action Items to reflect the advice of @fyliu to have the dev perform testing in their personal dockerhub account. But I'm unclear on what will happen after the dev submits the Pull Request to the ghpages-docker repository. How will a second developer be able to generate and test an image on the hackforla dockerhub prior to merging the PR? And should the second developer be someone who already has write access to the ghpages-docker repo? |
@roslynwythe I am going to add this to the agenda for this weeks Ops repo meeting and ask their advice. |
@roslynwythe The Ops community passed on it and suggested we reach out to engineering. I will add it to their agenda and attend their meeting. |
On ops, there is an issue that probably will need to be moved to engineering or combined with this issue https://github.com/hackforla/ops/issues/128 |
Turns out that new people with an M1 are not reporting problems (@tony1ee). So we are closing as unplanned |
Overview
We need to update our Docker file to support multiple platforms, in order to resolve a problem experienced by users with mac M1 processors
Action Items
.github/workflows/build-and-push-to-docker-hub.yml
workflow and/or Dockerfile to support platformslinux/amd64
andlinux/arm64
DOCKER_USERNAME
andDOCKER_PASSWORD
from the dockerhub accountResources/Instructions
The text was updated successfully, but these errors were encountered: