Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Daniel Ridge workflows #6979

Closed
8 tasks done
roslynwythe opened this issue Jun 10, 2024 · 5 comments
Closed
8 tasks done

Updates to Daniel Ridge workflows #6979

roslynwythe opened this issue Jun 10, 2024 · 5 comments
Assignees
Labels
Complexity: Medium Feature: Docker GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe

Comments

@roslynwythe
Copy link
Member

roslynwythe commented Jun 10, 2024

Overview

As developers we need to update the deprecated set-output command in the Daniel Ridge workflows and update the version of Node, in order to comply with GitHub recommendations and ensure the continuing operation of the workflows. There is also an issue with the secret that must be resolved.

Details

Action Items

  • Fork and clone the repository check-ghpages-versions.
  • Based on the guidelines in GitHub Actions: Deprecating save-state and set-output commands, update .github/workflows/check-gh-pages-version.yml and .github/workflows/check-ruby-version.yml so that the result of the step 'Check for modified files is set using Environment files instead of set-output
  • Based on the guidelines in GitHub Actions: Transitioning from Node 16 to Node 20 update the code to remove dependencies on Node 16. This will require replacing actions/checkout@v3 with actions/checkout@v4
  • create a PAT in your repository, then a secret called test_Daniel_Ridge_PAT and modify each workflow to use that secret in place of GH_TOKEN: ${{ secrets.Daniel_Ridge_PAT }}
  • As described in How To Use section of the Keep-Alive Workflow documentation, workflow permissions must be set. Go to repository settings, Click on Actions > General. Update the "Workflow permissions" to "Read and write permissions". Click on save.
  • Test by running .github/workflows/check-gh-pages-version.yml and verify that the appropriate issues were created
  • Restore the original secret
  • Create a PR in https://github.com/danielridgebot/check-ghpages-versions. Put this issue in "Questions/In Review" and apply the label "ready for dev lead".

Resources/Instructions

GHA log showing failed run

image

Check Github Pages Gem Version and Open New Issue on Change

Check Ruby Version and Open New Issue on Change

check-gh-pages-version.yml

check-ruby-version

GitHub blog post - GitHub Actions: Deprecating save-state and set-output commands

GitHub Actions: Transitioning from Node 16 to Node 20

@roslynwythe roslynwythe added Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jun 10, 2024

This comment was marked as outdated.

@roslynwythe roslynwythe added Draft Issue is still in the process of being created Complexity: Medium Feature: Docker size: 1pt Can be done in 4-6 hours role: back end/devOps Tasks for back-end developers and removed Feature Missing This label means that the issue needs to be linked to a precise feature label. size: missing role missing Complexity: Missing labels Jun 10, 2024
@roslynwythe roslynwythe changed the title Update deprecated set-output command in Daniel Ridge workflows Updates to Daniel Ridge workflows Jun 13, 2024
@roslynwythe roslynwythe added Ready for Prioritization and removed Draft Issue is still in the process of being created labels Jun 13, 2024
@ExperimentsInHonesty ExperimentsInHonesty added time sensitive Needs to be worked on by a particular timeframe and removed Ready for Prioritization labels Jun 15, 2024
@andyphancode andyphancode self-assigned this Jun 16, 2024
Copy link

Hi @andyphancode, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

@andyphancode
Copy link
Member

andyphancode commented Jun 16, 2024

Availability: Throughout 6/15/24 - 6/18/24
ETA: EOD 6/17/24

@andyphancode andyphancode added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Jun 17, 2024
@andyphancode
Copy link
Member

@ExperimentsInHonesty ExperimentsInHonesty added GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board role: back end and removed role: back end/devOps Tasks for back-end developers labels Jun 18, 2024
@ExperimentsInHonesty ExperimentsInHonesty added the role: back end/devOps Tasks for back-end developers label Jun 18, 2024
@ExperimentsInHonesty ExperimentsInHonesty moved this to Questions / In Review in P: HfLA Website: Project Board Jun 23, 2024
@roslynwythe roslynwythe removed ready for dev lead Issues that tech leads or merge team members need to follow up on Added to dev/pm agenda labels Aug 11, 2024
@t-will-gillis t-will-gillis added the ready for dev lead Issues that tech leads or merge team members need to follow up on label Aug 11, 2024
@roslynwythe roslynwythe removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Aug 14, 2024
@roslynwythe
Copy link
Member Author

@github-project-automation github-project-automation bot moved this from Questions / In Review to QA in P: HfLA Website: Project Board Aug 14, 2024
@kgold2018 kgold2018 moved this from QA to Done in P: HfLA Website: Project Board Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Medium Feature: Docker GHA New Project Board compatible This GitHub Action issue does not reference columns and will work with the new board role: back end/devOps Tasks for back-end developers size: 1pt Can be done in 4-6 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

No branches or pull requests

4 participants