-
-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates to Daniel Ridge workflows #6979
Comments
This comment was marked as outdated.
This comment was marked as outdated.
set-output
command in Daniel Ridge workflows
Hi @andyphancode, thank you for taking up this issue! Hfla appreciates you :) Do let fellow developers know about your:- You're awesome! P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :) |
Availability: Throughout 6/15/24 - 6/18/24 |
Pull request created at https://github.com/danielridgebot/check-ghpages-versions/pulls |
Overview
As developers we need to update the deprecated
set-output
command in the Daniel Ridge workflows and update the version of Node, in order to comply with GitHub recommendations and ensure the continuing operation of the workflows. There is also an issue with the secret that must be resolved.Details
The Daniel Ridge Bot repo check-ghpages-versions contains the scheduled workflows
check-gh-pages-version.yml
andcheck-ruby-version.yml
which automatically check the dependencies for the Docker image, and generate issues in the ops repository (github.com/hackforla/ops) if an update is required.The workflow had stopped running due to inactivity in the repository. Implement "Keep-Alive" for Daniel Ridge bot so that Docker image will be updated #6266 was created to add a "keepalive" step to prevent the workflow from stopping in the future
However, even when the repository is active, the workflows do not behave as expected. See the Resources/Instructions section for a screenshot of a log depicting the current behavior. In addition, the following warnings are observed:
The
set-output
command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commandsNode.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/
Based on this comment Add Keepalive Workflow to Check GH Pages Version Workflow danielridgebot/check-ghpages-versions#21 (comment), the secret name referenced in the workflows is incorrect and needs to be updated.
Action Items
.github/workflows/check-gh-pages-version.yml
and.github/workflows/check-ruby-version.yml
so that the result of the step 'Check for modified files is set using Environment files instead ofset-output
actions/checkout@v3
withactions/checkout@v4
.github/workflows/check-gh-pages-version.yml
and verify that the appropriate issues were createdResources/Instructions
GHA log showing failed run
Check Github Pages Gem Version and Open New Issue on Change
Check Ruby Version and Open New Issue on Change
check-gh-pages-version.yml
check-ruby-version
GitHub blog post - GitHub Actions: Deprecating save-state and set-output commands
GitHub Actions: Transitioning from Node 16 to Node 20
The text was updated successfully, but these errors were encountered: