feat: ✨ social-auth auto associate existing user #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goztrk
commented
Dec 13, 2024
There was a problem hiding this comment.
Reviewer's Note
Most of this is formatting. The important part is marked with a comment.
Comment on lines
+96
to
+106
| # A user is already associated with this email | ||
| auto_associate_backends = htk_setting( | ||
| 'HTK_ACCOUNTS_SOCIAL_AUTO_ASSOCIATE_BACKENDS', [] | ||
| ) | ||
| backend_name = backend.name | ||
| if backend_name in auto_associate_backends: | ||
| # The backend is one of the auto-associate backends, so we need to | ||
| # associate the Django user with the social auth account | ||
| # This is a job for `associate_user` pipeline but the association | ||
| # must happen in here. | ||
| associate_user(backend, uid, user=user) |
There was a problem hiding this comment.
Reviewer's Note
The main change!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows desired social auth backends to be defined as auto-associate. This will allow to associate social accounts with existing accounts in the pipeline automatically.