Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'borderRadius' problem on Android #1

Open
bekircanbozkurt opened this issue Aug 9, 2023 · 5 comments
Open

'borderRadius' problem on Android #1

bekircanbozkurt opened this issue Aug 9, 2023 · 5 comments

Comments

@bekircanbozkurt
Copy link

First of all, congratulations for making this package workable in CLI projects. I've installed the package, but I'm facing a particular issue. In the original version of the package, the menu that opens in the Android environment was in a 'rounded' shape. I can see that the 'borderRadius' is set in the style file of the menuContainer component. However, while it works in the original version, it doesn't work in the version you've worked on. As a temporary solution, I added 'borderRadius' to the menuInnerContainer style, and it fixed the issue. However, I'm not entirely sure if this is the correct approach. In the original version, the reanimated version is lower than the version in your adaptation. Could this be related?

@hadnet
Copy link
Owner

hadnet commented Aug 9, 2023

First of all, congratulations for making this package workable in CLI projects. I've installed the package, but I'm facing a particular issue. In the original version of the package, the menu that opens in the Android environment was in a 'rounded' shape. I can see that the 'borderRadius' is set in the style file of the menuContainer component. However, while it works in the original version, it doesn't work in the version you've worked on. As a temporary solution, I added 'borderRadius' to the menuInnerContainer style, and it fixed the issue. However, I'm not entirely sure if this is the correct approach. In the original version, the reanimated version is lower than the version in your adaptation. Could this be related?

Thanks for bringing up this issue, Bekircan. It could probably be a version difference. Did you manage to install a lower version and check if that was the case? I used a newer versions of Reanimated because I need to use the new features. I haven't tested this pkg on Android yet, as it was more for my personal use on iOS. I'll try to take a look over the weekend. In any case, any PR will be welcome.

@bekircanbozkurt
Copy link
Author

bekircanbozkurt commented Aug 10, 2023

First of all, congratulations for making this package workable in CLI projects. I've installed the package, but I'm facing a particular issue. In the original version of the package, the menu that opens in the Android environment was in a 'rounded' shape. I can see that the 'borderRadius' is set in the style file of the menuContainer component. However, while it works in the original version, it doesn't work in the version you've worked on. As a temporary solution, I added 'borderRadius' to the menuInnerContainer style, and it fixed the issue. However, I'm not entirely sure if this is the correct approach. In the original version, the reanimated version is lower than the version in your adaptation. Could this be related?

Thanks for bringing up this issue, Bekircan. It could probably be a version difference. Did you manage to install a lower version and check if that was the case? I used a newer versions of Reanimated because I need to use the new features. I haven't tested this pkg on Android yet, as it was more for my personal use on iOS. I'll try to take a look over the weekend. In any case, any PR will be welcome.

I've also found another bug. The function inside 'onPress' is not working. The reason for this is due to the version of Reanimated. When we want to use the new version, the 'onPress' event in 'menuProps' is being converted from the 'function' type to '__remoteFunction', causing it not to work. I'm working on it, but I need your support to resolve it.

Error is here :
Screenshot 2023-08-10 at 17 52 42

@hadnet
Copy link
Owner

hadnet commented Aug 10, 2023

I guess it's something related to this Reanimated 3 issue software-mansion/react-native-reanimated#4613 (comment)

I also highlighted this in the Readme.md
Screenshot 2023-08-10 at 12 56 42 PM

@bekircanbozkurt
Copy link
Author

I guess it's something related to this Reanimated 3 issue software-mansion/react-native-reanimated#4613 (comment)

I also highlighted this in the Readme.md Screenshot 2023-08-10 at 12 56 42 PM

Thank you, now there is no error but __remoteFunction is empty. Why returns empty object ?

@bekircanbozkurt
Copy link
Author

bekircanbozkurt commented Aug 11, 2023

Were you able to look into the issue with '__remoteFunction'? @hadnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants