Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Nat instead of Natural for De Bruijn index #3

Open
hagl opened this issue Jan 10, 2022 · 1 comment
Open

Use Nat instead of Natural for De Bruijn index #3

hagl opened this issue Jan 10, 2022 · 1 comment
Assignees
@hagl
Labels
performance

Comments

@hagl
Copy link
Owner

hagl commented Jan 10, 2022

I used the dhall reference implementation dhall-lang/standard as the basis when creating the types for the AST and also copied the unlimited precision integer Natural for the DeBruijn index of Expression.Variable. In reality a Nat will always be sufficient and would probably speed up shifting and unshifting of the indexes quite a bit.
@hagl
Copy link
Owner Author

hagl commented Jan 29, 2022

Baseline for testsuite:

1468 total tests ( ✅ 1465 passed, 🚫 3 failed) in directory /Users/harald/projects/dhall-unison/dhall-lang
Duration: 705.843s
1468 total tests ( ✅ 1465 passed, 🚫 3 failed) in directory /Users/harald/projects/dhall-unison/dhall-lang
Duration: 712.027s
1468 total tests ( ✅ 1465 passed, 🚫 3 failed) in directory /Users/harald/projects/dhall-unison/dhall-lang
Duration: 681.124s

@hagl hagl self-assigned this Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hagl hagl

Labels
performance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hagl