Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ManaToolkit as a new modules, and fixed ngrep. #37

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Added ManaToolkit as a new modules, and fixed ngrep. #37

wants to merge 5 commits into from

Conversation

adde88
Copy link
Contributor

@adde88 adde88 commented Aug 18, 2018

I've added ManaToolkit as a module now. You guys decide if you want this to be an official module yet. It's working.

I've also added some changes to ngrep.
Ngrep isn't working because the package doesn't exist on the official openwrt repos.
So the changes i've made to the dependencies.sh script now downloads ngrep from my repo, which is the latest version compiled with the correct libpcap version. :)

adde88 added 4 commits August 18, 2018 13:32
… So, you guys decide if you want to have this into your list of modules
…it now downloads it from my repo. Latest version, compiled with correct version of libpcap
Copy link

@moliata moliata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!

@WhistleMaster
Copy link
Contributor

WhistleMaster commented Aug 24, 2018

Responder can be updated but the module has to be updated in consequence (e.g. adding the --ProxyAuth option in the GUI, otherwise it's not usable).

Did not know that ngrep was not in the officiel repo anymore. I'll have a look with @sebkinne with if it could be brought back as it would be more efficient to keep it in Hak5 official repo.

Edit: I've sent a PR with adding the new version of Responder with the changes in the module itself.

@sebkinne
Copy link
Contributor

HI @adde88 thanks for making the PR! Could you please take out your ngrep fix for now? @WhistleMaster made some changes and I would like a PR for a new module to stand on it's own :)

@WhistleMaster
Copy link
Contributor

@sebkinne Would it be possible to bring back ngrep in the official repo ?

@adde88
Copy link
Contributor Author

adde88 commented Aug 29, 2018

@sebkinne
I've now removed the part of the script that pulls ngrep from my repo. as requested.
It should now attempt to use openwrt+hak5 repos. when downloading, as would be best. :)

@pidgy
Copy link
Contributor

pidgy commented Aug 30, 2018

@adde88 You should make the ngrep fix a different pull request on its own.

@WhistleMaster
Copy link
Contributor

WhistleMaster commented Aug 30, 2018

Well, it should not in my opinion as the hak5 philosophy is to keep binary in the official repo, not in third party ones.

And also, except the binary downloaded from another git, no changes were made in the ngrep module in it-self.

@adde88
Copy link
Contributor Author

adde88 commented Sep 4, 2018

The best option is definitely to keep the packages on the official Hak5 repos.
Then we atleast know who compiled the package and the binaries inside the repo.

When doing it like this there's a level of trust involved, as there's nothing stopping me (in theory) from adding malicious code to the binaries that are being launched on your Pineapples.
Which would be a very bad thing to make all the modules use. 😮

@foxtrot foxtrot self-assigned this Jul 9, 2019
@foxtrot foxtrot removed their assignment Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants