Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: Use CommandModule #3

Open
sjrct opened this issue Oct 5, 2017 · 1 comment
Open

Update: Use CommandModule #3

sjrct opened this issue Oct 5, 2017 · 1 comment

Comments

@sjrct
Copy link
Member

sjrct commented Oct 5, 2017

We should use the command module for all modules that parse commands.

Relevant PR: halibot/halibot#36

@richteer
Copy link

richteer commented Oct 26, 2019

Non-authoritative list ofcandidate modules for CommandModule. Not all are necessarily good fits for conversion, but it is worth taking a look at the following:

  • dice
  • mastermind (probably not)
  • quote
  • stackmemory
  • tz
  • emote
  • timer (maybe?)
  • btc
  • reminders
  • geoip
    probably others...

Some tips:

  • look for modules that basically only ever react to a command
  • modules that already split command logic into functions should be trivial to convert
  • modules that have a lot of extra processing in .receive() may be a pain to convert
    • especially modules that also read bare strings or other sequences, unless you want to override .receive() carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants