Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Go to Declaration or Usages" when tab is closed #82

Closed
elendil-software opened this issue Jul 27, 2021 · 3 comments
Closed

"Go to Declaration or Usages" when tab is closed #82

elendil-software opened this issue Jul 27, 2021 · 3 comments
Assignees

Comments

@elendil-software
Copy link

Describe the bug
When a tab is closed either by middle mouse button click or Right-click --> Close, a notification "Go to Declaration or Usages" is displayed

To Reproduce
Steps to reproduce the behaviour:

  1. Open a few files
  2. Click with the middle mouse button or by right-click --> Close to close a tab
  3. The notification "Go to Declaration or Usages"

Expected behaviour
It should display a notification suggesting to use the shortcut to close the current tab if the action is on the active tab or do nothing if the action is not on active tab.

Please also provide:

  • OS: Windows 10 Pro
  • Rider 2021.1.5
@halirutan
Copy link
Owner

Unfortunately, I could not reproduce this with Rider 2021.3.3 (Linux) anymore, but I've seen such things in the past. The problem with these issues is that I can't really do much about them. The Key Promoter relies on listening what the IDE thinks it is doing. So if Rider was sending out a "Go to Declaration" action, there is no way for me to decide if this is correct or not.

However, your issue finally got me testing the plugin with Rider which I usually don't use and it brought up another important issue: The tool windows like "Explorer", "Problems", etc. have changed and I used an ugly hack to show tips for them. After looking into it, I removed the hack completely and relied on something that's also used internally in IntelliJ.

@elendil-software
Copy link
Author

On Windows with version 2021.3.3, the issue seems to be solved when using contextual menu (right click) but remains when using middle click.

@halirutan halirutan reopened this Feb 14, 2022
@halirutan
Copy link
Owner

Yes, you are right it's still there. We have an open "not my fault" issue. It's unfortunate for the Rider on Windows people, but I can't fix this. Rider sends the information that Go to decl. is used when the tab is closed and I just display it. We have an open issue for this bug that will stay open until Rider fixes the underlying issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants