-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a consistent Code style #295
Comments
That's unfortunate. My preference is for 2 spaces (I like to conserve horizontal line space). This is not just the thing about initial indentation vs further indentation? |
… Google's CheckStyle specs). Formatted existing .java code to match. See hamcrest#295
If it is simply an indentation concern, then I think it's straightforward to address that using CheckStyle to assist with a consistent code style. I've opened up a PR which adds such a rule. |
… Google's CheckStyle specs). Formatted existing .java code to match. See hamcrest#295
Yes, thanks @brownian-motion, that's what I meant. |
I like this idea, but I'm only familiar with a small set of style settings. I know IntelliJ can import code style from CheckStyle, can Eclipse or other IDEs do the same? If all can, it may be simple enough to define a CheckStyle file. |
I don't know, but if we want to keep it simple, we may just use Google's styles: they are using 2 spaces anyways. |
While working on #294 I noticed there's a bit of a mess from a code style point of view.
See e.g. IsCollectionWithSize: there's a mix of tabs with 2 spaces and others with 4 spaces.
The text was updated successfully, but these errors were encountered: