Allow installation of PHPUnit 8 in order to test with PHP 8.1 and 8.2 #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villfa
changed the title
|
@villfa , have the changes you've made introduced these risky tests or warnings? |
|
No, I don't think so. |
aik099
approved these changes
Oct 16, 2023
|
I've marked PR as approved. I'll wait for other maintainers to review it as well. |
It has been 2 months. Should we ping some of them? |
|
@villfa , let's merge it. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows the installation of PHPUnit 8.
After installation, when executed, it generates warnings and mark some tests as risky though.
Please tell me if you prefer they are fixed with this PR or in a subsequent one.
To be honest I didn't go further because I first wanted to be sure the project is still maintained.