std_web_publisher: Check for file download permissions functions will always be true

[thomas-]

Minor find, but I think these two if checks are going to be always true, but it seems the intent is for them to be false if no file download permissions functions are added.

Perhaps it should be if(this._fileDownloadPermissionFunctions.length)?

haplo-standard-plugins-dev/std_web_publisher/js/std_web_publisher.js

Lines 502 to 509 in 49ac233

	if(this._fileDownloadPermissionFunctions) {
	endLines.push("Disallow: /thumbnail/");
	}
	} else {
	if(this._fileDownloadPermissionFunctions) {
	// Special case because file downloads don't use normal publisher handlers
	lines.push("Allow: /download/");
	}

Publication constructors execute this._setupForFileDownloads();

haplo-standard-plugins-dev/std_web_publisher/js/std_web_publisher.js

Lines 151 to 162 in 49ac233

	var Publication = P.Publication = function(name, plugin) {
	this.name = name;
	this.implementingPlugin = plugin;
	this._homePageUrlPath = null;
	this._pagePartOptions = {};
	this._paths = [];
	this._urlPolicy = O.refdictHierarchical();
	this._objectTypeHandler = O.refdictHierarchical();
	this._searchResultsRenderers = O.refdictHierarchical(); // also this._defaultSearchResultRenderer
	this._replacedTemplates = {};
	this._setupForFileDownloads();
	};

Which sets this._fileDownloadPermissionFunctions = [];

haplo-standard-plugins-dev/std_web_publisher/js/std_web_publisher_files.js

Lines 136 to 139 in 49ac233

	P.Publication.prototype._setupForFileDownloads = function() {
	this._fileThumbnailSize = DEFAULT_THUMBNAIL_SIZE;
	this._fileDownloadPermissionFunctions = [];
	};