-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ingress anotation timeout-server does not change haproxy config #617
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
I read on Slack I am not the only one who experienced the bug. |
Hi @dosmanak , I'm looking at it, thanks for reporting. |
It seems the documentation for annotation is not aligned with the code on this because of the possibility of using CRD for that. But as the annotation is present at configmap level, we'll add the missing annotations for ingress and service resources. Thanks for reporting. |
Hello, @ivanmatmati I noticed that this bug isn't reproducible on the 1.11 branch. After bisecting, I found out that commit e2f797c fixes this issue. Perhaps we should consider backporting it to the 1.10 branch |
Hi @fabianonunes , you're correct and actually I made a mistake because the version that @dosmanak uses does not provide the annotation for service and ingress. As you noticed only 1.11 does. We'll consider to backport it as you suggested. |
I added annotation
haproxy.org/timeout-server: 15m
to ingress manifest but generated backend does not containtimeout server
directive.annotations:
haproxy.cfg backend
Version is haproxytech/kubernetes-ingress:1.10.7
The text was updated successfully, but these errors were encountered: