Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to understand the mode for tcpcr in 3.0.0 #658

Closed
cxfcxf opened this issue Jun 28, 2024 · 5 comments
Closed

Try to understand the mode for tcpcr in 3.0.0 #658

cxfcxf opened this issue Jun 28, 2024 · 5 comments
Labels

Comments

@cxfcxf
Copy link
Contributor

cxfcxf commented Jun 28, 2024

https://github.com/haproxytech/kubernetes-ingress/blob/master/pkg/handler/tcp-cr.go#L139
in this code, it forces the frontend to have mode tcp

but in the TCP CR doc here

it is said to allow mode http or tcp in CRD. i am confused here, is that http for something else or its just not implanted?

@hdurand0710
Copy link
Contributor

hdurand0710 commented Jun 28, 2024

@cxfcxf ,
You are right. We will update the documentation accordingly.
You can use all fields of a client native Frontend model, expect the mode that is forced to tcp.
The documentation here was auto generated from the Backend model, we should explain that mode is not used and if used would we forced to tcp.

@cxfcxf
Copy link
Contributor Author

cxfcxf commented Jun 28, 2024

thanks, i m also wondering if there is a plan to support more bind params in http/https handler?

we try to split thread for http and https works, but it seems its not supported.

@cxfcxf
Copy link
Contributor Author

cxfcxf commented Jul 9, 2024

so i sent a PR for the supporting thread pin on http https and healthz which can be helpful for people runnign it as external mode

#661

@oktalz
Copy link
Member

oktalz commented Jul 30, 2024

thanks, i m also wondering if there is a plan to support more bind params in http/https handler?

yes, ideally we end up with a frontend CRD completely, its in plans

Copy link

stale bot commented Sep 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 1, 2024
@stale stale bot closed this as completed Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants