Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose constants/enums? #69

Open
papandreou opened this issue Jan 9, 2023 · 4 comments
Open

Expose constants/enums? #69

papandreou opened this issue Jan 9, 2023 · 4 comments
Labels
help wanted Extra attention is needed

Comments

@papandreou
Copy link
Contributor

Hi,

It feels a bit dirty to hardcode constants like this, especially if they're subject to change in new major versions:

Is there any way those somehow be included with harfbuzzjs?

@chearon
Copy link
Contributor

chearon commented Jan 9, 2023

I have had this problem with every WebAssembly project I've worked on. It does look like Emscripten has a way of exposing C++ enums and constants to JS, which could be used now that this project uses Emscripten.

@khaledhosny
Copy link
Contributor

HarfBuzz is ABI and API stable, these values don't change across releases, even major ones.

@papandreou
Copy link
Contributor Author

Okay, that makes me feel slightly less worried about hardcoding them. Still, I think it would be worth it to expose them as a pure DX/discoverability thing?

@khaledhosny
Copy link
Contributor

Sure, if someone wants to do it.

@khaledhosny khaledhosny added the help wanted Extra attention is needed label Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants