-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Apple tests in CI #113
Conversation
@behdad Do you know whether it's a bug or "intended" that the following two commands yield different results?
I'm not sure if passing EDIT: Ah, I guess while the numbers are different, the visual result itself should be the same. |
So we did had one bug in Having our copy of |
Two more bugs actually. But yes, luckily not a lot of bugs.
The thing is that some of the font paths changed apparently, meaning that we would lose many tests just because the font path changed, which would be kind of a waste... I don't think
Well, right now we basically ignore them, because as mentioned in the file I don't think we need to bother with running on different MacOS versions, we always run on MacOS 14 for now, and we use the output from harfbuzz as our test oracle. I think that is the cleanest approach for now. |
Alright, it works now. :D So we can merge this after harfbuzz/ttf-parser#157 is merged. |
Ok, makes sense. |
Nice! I'll attempt to port the |
Nearly done, just one failing test case I need to investigate.