Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test covering incorrect application of avar table #137

Merged
merged 3 commits into from
Oct 4, 2024

Conversation

maxmelander
Copy link
Contributor

Adds test to cover the issue where the avar table was beeing applied to the same coordinate multiple times when calling set_variations ( #136 ).

This test will pass when harfbuzz/ttf-parser@1cac7c7 is taken into use.

Adds test to cover the issue where the avar table was
beeing applied to the same coordinate multiple times when
calling set_variations. This test will pass when commit
1cac7c7 from ttf-parser starts being used.
@RazrFalcon
Copy link
Collaborator

I have updated ttf-parser, so the test should not fail anymore.
But since we auto-generate tests, there are a couple more steps needed.

  1. Put your test data into tests/custom/bugs.tests.
  2. Move the font to tests/fonts/rb_custom.
  3. Move variations_006 to tests/shaping/custom.rs as bugs_002.

That should be enough.

@RazrFalcon RazrFalcon merged commit 2585832 into harfbuzz:master Oct 4, 2024
2 checks passed
@RazrFalcon
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants