Fix treating null offsets as error in GSUB #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazrFalcon
reviewed
Jun 15, 2024
RazrFalcon
reviewed
Jun 15, 2024
|
Looks good. I guess I've missed this edge case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I was facing problems with a new font added in harfbuzz, and turns out that the reason was that a specific GSUB lookup failed to parse properly. After looking at the spec, I noticed the following:
Offsets cann be NULL, which wasn't checked for in our implementation. This is the least invasive approach I could think of (requires no changes in rustybuzz), and the test case passes now as well, so I hope it's okay.