Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

localnet with multi bls #4793

Merged
merged 1 commit into from
Nov 25, 2024
Merged

localnet with multi bls #4793

merged 1 commit into from
Nov 25, 2024

Conversation

sophoah
Copy link
Contributor

@sophoah sophoah commented Nov 7, 2024 •
edited
Loading

what was done:

  • localnet for a multi bls setup by adding a new config file, create the folders for blskeys per node and update deploy.sh accordingly
  • Makefile - add new target pre-external for common command to run, and new target debug-multi-bls to start the localnet in this mode
  • Update debug.sh to accept in argument the local network config and remove debug-external.sh

@Frozen
Copy link
Contributor

Frozen commented Nov 7, 2024

it passed tests locally for me

@sophoah
Copy link
Contributor Author

sophoah commented Nov 22, 2024

@Frozen @mur-me @GheisMohammadi let's approve that one. the mult-bls node with quorum bug will be fixed with #4799

@sophoah sophoah merged commit 8172901 into harmony-one:dev Nov 25, 2024
3 checks passed
@sophoah sophoah deleted the feat/local-multi-bls branch November 25, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GheisMohammadi GheisMohammadi GheisMohammadi approved these changes

@mur-me mur-me mur-me approved these changes

@Frozen Frozen Awaiting requested review from Frozen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sophoah @Frozen @mur-me @GheisMohammadi