Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The eslint-parser version does not support latest eslint-parser version of airbnb #31

Open
karendolan opened this issue Jun 11, 2024 · 2 comments

Comments

@karendolan
Copy link
Member

When running % npm init dce-eslint@latest from https://harvard-edtech.github.io/edtech-guide/
I got the following error. Implying the version of eslint parser had a conflict with the existing dependency. I think it is the version that is in the caccl is lower (v5) than the one wanted by airbnb eslint (v7)

Caccl dependency:
https://github.com/harvard-edtech/caccl/blob/main/package-lock.json#L336-L337

Error:

SUCCESS eslint-config-airbnb
  and its peerDeps were installed successfully.
npm error code ERESOLVE
npm error ERESOLVE could not resolve
npm error
npm error While resolving: [email protected]
npm error Found: @typescript-eslint/[email protected]
npm error node_modules/@typescript-eslint/eslint-plugin
npm error   @typescript-eslint/eslint-plugin@"^5.5.0" from [email protected]
npm error   node_modules/eslint-config-react-app
npm error     eslint-config-react-app@"^7.0.1" from [email protected]
npm error     node_modules/react-scripts
npm error       react-scripts@"5.0.1" from the root project
npm error   peerOptional @typescript-eslint/eslint-plugin@"^4.0.0 || ^5.0.0" from [email protected]
npm error   node_modules/eslint-plugin-jest
npm error     eslint-plugin-jest@"^25.3.0" from [email protected]
npm error     node_modules/eslint-config-react-app
npm error       eslint-config-react-app@"^7.0.1" from [email protected]
npm error       node_modules/react-scripts
npm error         react-scripts@"5.0.1" from the root project
npm error   1 more (the root project)
npm error
npm error Could not resolve dependency:
npm error dev @typescript-eslint/eslint-plugin@"*" from the root project
npm error
npm error Conflicting peer dependency: @typescript-eslint/[email protected]
npm error node_modules/@typescript-eslint/parser
npm error   peer @typescript-eslint/parser@"^7.0.0" from @typescript-eslint/[email protected]
npm error   node_modules/@typescript-eslint/eslint-plugin
npm error     dev @typescript-eslint/eslint-plugin@"*" from the root project
npm error
npm error Fix the upstream dependency conflict, or retry
npm error this command with --force or --legacy-peer-deps
npm error to accept an incorrect (and potentially broken) dependency resolution.
npm error
@karendolan
Copy link
Member Author

FYI - using --force, as recommended in the error message, gave a success.

SUCCESS eslint-config-airbnb
  and its peerDeps were installed successfully.
npm warn using --force Recommended protections disabled.
npm warn ERESOLVE overriding peer dependency

@gabeabrams
Copy link
Contributor

@karendolan could you create a PR with the appropriate updates to the eslint versions?

That said, I am a tad confused because dev dependencies shouldn't matter when using caccl as a dependency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants