Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add an optional extra top header menu item #221

Open
OriHoch opened this issue May 30, 2021 · 3 comments
Open

add an optional extra top header menu item #221

OriHoch opened this issue May 30, 2021 · 3 comments
Assignees
@niryariv

Comments

@OriHoch
Copy link
Contributor

OriHoch commented May 30, 2021 •
edited
Loading

site settings should have 2 additional fields (both optional, default empty):

  • extra top header menu item text hebrew
  • extra top header menu item link hebrew

when both fields have a value on the relevant site, an extra top header menu item will be displayed at this location for the hebrew site only:

image
@OriHoch
Copy link
Contributor Author

OriHoch commented May 30, 2021

estimate: 2-5 hours

@OriHoch OriHoch mentioned this issue May 30, 2021
Closed
@OriHoch
Copy link
Contributor Author

OriHoch commented May 30, 2021

because we currently don't have a language switcher, the extra item will be visible only in hebrew site

@niryariv
Copy link

Please do not implement for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niryariv niryariv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@niryariv @OriHoch