Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ValidEmail needs better diagnosis messages #162

Open
jace opened this issue Sep 20, 2017 · 0 comments
Open

ValidEmail needs better diagnosis messages #162

jace opened this issue Sep 20, 2017 · 0 comments

Comments

@jace
Copy link
Member

jace commented Sep 20, 2017

In the ValidEmail validator, we return the same error message regardless of what the diagnosis is. There are two situations where this is a problem:

  1. Temporary lookup failure. This is confusing to users, who may try again and find that it works the second time. They should be explicitly asked to do so.

  2. Missing MX record. This is very confusing to users, since they can receive email without MX and don't understand what is wrong. ValidEmail should explicitly point out that MX is missing.

Further, failure on missing MX should be optional and accepted as an init parameter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant