From a1da11b814f925477dbed2b54483ca5f98f5b9a9 Mon Sep 17 00:00:00 2001
From: anishTP <119032387+anishTP@users.noreply.github.com>
Date: Sat, 16 Nov 2024 11:31:41 +0530
Subject: [PATCH] Add primary venue title to project card footer (#2136)

* Add primary venue title to project card

* Flattened nested if conditions in the project card footer

* Use trans tag when there's a comma; indent if statements

* Fixed missing references to featured_project

---------

Co-authored-by: Kiran Jonnalagadda <kiran@hasgeek.com>
---
 funnel/templates/macros.html.jinja2         | 15 +++++++++++++--
 funnel/templates/profile_layout.html.jinja2 | 19 ++++++++++++++++---
 2 files changed, 29 insertions(+), 5 deletions(-)

diff --git a/funnel/templates/macros.html.jinja2 b/funnel/templates/macros.html.jinja2
index 4e8745af6..37b1498ef 100644
--- a/funnel/templates/macros.html.jinja2
+++ b/funnel/templates/macros.html.jinja2
@@ -190,8 +190,19 @@
           <p class="mui--text-body2 mui--text-light zero-top-margin search-snippets">{{ faicon(icon='search', css_class="search-icon", baseline=false) }} {{ snippet_html }}</p>
         {% endif %}
         <div class="flex-wrapper flex-wrapper--end flex-wrapper--space-between flex-wrapper--wrap top-padding">
-          {%- if include_details %}
-            <div class="card__body__location mui--text-light">{% if project.primary_venue %}{{ faicon(icon='map-marker-alt', icon_size='caption', baseline=false) }} {% if project.primary_venue.city %}{{ project.primary_venue.city }}{% else %}{{ project.primary_venue.title }}{% endif %}{% elif project.location %}{{ faicon(icon='map-marker-alt', icon_size='caption', baseline=false) }} {{ project.location }}{% endif %}</div>
+          {%- if include_details and (project.primary_venue or project.location) -%}
+            <div class="card__body__location mui--text-light">
+              {{ faicon(icon='map-marker-alt', icon_size='caption', baseline=false) }}
+              {%- if project.primary_venue.title and project.primary_venue.city %}
+                {% trans venue=project.primary_venue.title, city=project.primary_venue.city -%}
+                  {{ venue }}, {{ city }}
+                {%- endtrans %}
+              {%- elif project.primary_venue.title %}
+                {{ project.primary_venue.title }}
+              {%- elif project.location %}
+                {{ project.location }}
+              {%- endif -%}
+            </div>
           {% endif %}
         </div>
       </div>
diff --git a/funnel/templates/profile_layout.html.jinja2 b/funnel/templates/profile_layout.html.jinja2
index 7eb466319..d444f2738 100644
--- a/funnel/templates/profile_layout.html.jinja2
+++ b/funnel/templates/profile_layout.html.jinja2
@@ -126,9 +126,22 @@
                     <div class="mui--hidden-lg mui--hidden-xl">
                       <h3 class="card__body__title mui--text-subhead {% if not featured_project.start_at %} card__body__subtitle {% endif %}"><a href="{{ featured_project.url_for() }}" class="mui--text-dark nounderline"><span class="text-bold">{{ featured_project.title_inline }}</span> <span class="mui--text-light js-truncate" data-truncate-lines="2">{{ featured_project.tagline }}</span></a></h3>
                     </div>
-                    <div class="flex-wrapper flex-wrapper--space-between flex-wrapper--center top-padding">
-                      <div class="card__body__location mui--text-light zero-bottom-margin">{% if featured_project.primary_venue %}{{ faicon(icon='map-marker-alt', icon_size='caption', baseline=false) }} {% if featured_project.primary_venue.city %}{{ featured_project.primary_venue.city }}{% else %}{{ featured_project.primary_venue.title }}{% endif %}{% elif featured_project.location %}{{ faicon(icon='map-marker-alt', icon_size='caption', baseline=false) }} {{ featured_project.location }}{% endif %}</div>
-                    </div>
+                    {%- if featured_project.primary_venue or featured_project.location %}
+                      <div class="flex-wrapper flex-wrapper--space-between flex-wrapper--center top-padding">
+                        <div class="card__body__location mui--text-light">
+                          {{ faicon(icon='map-marker-alt', icon_size='caption', baseline=false) }}
+                          {%- if featured_project.primary_venue.title and featured_project.primary_venue.city %}
+                            {% trans venue=featured_project.primary_venue.title, city=featured_project.primary_venue.city -%}
+                              {{ venue }}, {{ city }}
+                            {%- endtrans %}
+                          {%- elif featured_project.primary_venue.title %}
+                            {{ featured_project.primary_venue.title }}
+                          {%- elif featured_project.location %}
+                            {{ featured_project.location }}
+                          {%- endif -%}
+                        </div>
+                      </div>
+                    {%- endif %}
                   </div>
                 {% endif %}
               </div>